Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept EOF as well as newline to complete line read #404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shreve
Copy link

@shreve shreve commented Sep 20, 2019

Addresses #393 and #403.

Currently a line isn't read if any error is reached, including EAGAIN,
which indicates you've reached the end of a file descriptor.

This commit allows EAGAIN to terminate a line if anything else has been
read from that fd. If nothing else has been read, it's either
non-existent or empty, which makes sense to error instead.

Currently a line isn't read if any error is reached, including EAGAIN,
which indicates you've reached the end of a file descriptor.

This commit allows EAGAIN to terminate a line if anything else has been
read from that fd. If nothing else has been read, it's either
non-existent or empty, which makes sense to error instead.
@zsugabubus
Copy link

You shall modify sys.c too (at least), to prepare for EAGAIN during a normal operation (...so you can remove that len > 0 hack).

@zsugabubus zsugabubus mentioned this pull request May 24, 2020
dllud pushed a commit to dllud/i3blocks that referenced this pull request Jan 12, 2024
eyedropper: add support for Sway, and for copying to the clipboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants